Add a regression test for #15979, and fix linecount-report for Windows #20111
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
python#16019, which fixed this issue (for linux) was not accompanied by a regression test
wyattscarpenter
changed the title
for more information, see https://pre-commit.ci
wyattscarpenter
changed the title
This comment has been minimized.
This comment has been minimized.
sterliakov
approved these changes
Oct 24, 2025
|
I considered this TOCTOU problem, but I don't think there's a better way around it. I'm sure by the time someone files a bug report to complain about a crash caused by them replacing one of their files with a directory in the middle of report generation, python will have fixed its file-access bug :^) |
emmatyping
approved these changes
Oct 24, 2025
|
Oh and
yeah I don't think there's much to be done here |
|
Hopefully a big red "crash" label will help this set of PRs make it to the nearest release:) |
|
According to mypy_primer, this change doesn't affect type check results on a corpus of open source code. ✅ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#16019, which fixed this issue (for linux) was not accompanied by a regression test. Thus, nobody noticed that it doesn't work on Windows!
This fixes an Internal Error where namespace packages were not supported properly. This fix was inspired by @sterliakov noticing that #18128 was very similar to #19843, which has a similar fix. Note that we use
os.path.isdir(tree.path)instead of trying to catch anIsADirectoryErrorexception because of a bug on Windows which causes it to throw aPermissionErrorinstead in the relevant situation, which makesexcept IsADirectoryErrorunreliable. (We also can't justexcept (IsADirectoryError, PermissionError)because what if there is an actual permission error?)